Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add missing test for env file #56642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add missing test for env file #56642

wants to merge 1 commit into from
+12 −0

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented Jan 17, 2025

Adds missing test for #54255

Fixes #54255

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 17, 2025
@JonasBa JonasBa force-pushed the jb/dotenv/flag-prefix-match branch from 23dd771 to ee52995 Compare January 17, 2025 15:22
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 17, 2025
@JonasBa JonasBa force-pushed the jb/dotenv/flag-prefix-match branch from bd62bb0 to ee52995 Compare January 17, 2025 15:41
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 17, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (74717cb) to head (ee52995).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56642   +/-   ##
=======================================
  Coverage   89.21%   89.22%           
=======================================
  Files         662      662           
  Lines      191883   191883           
  Branches    36932    36938    +6     
=======================================
+ Hits       171198   171201    +3     
- Misses      13534    13541    +7     
+ Partials     7151     7141   -10

see 34 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dotenv::GetPathFromArgs matches --env-file*
5 participants
@JonasBa @lpinca @anonrig @jakecastelli @nodejs-github-bot