-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: support security prepare #665
lib: support security prepare #665
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
- Coverage 83.41% 83.38% -0.04%
==========================================
Files 37 37
Lines 4131 4158 +27
==========================================
+ Hits 3446 3467 +21
- Misses 685 691 +6
☔ View full report in Codecov by Sentry. |
17a048b
to
f045e77
Compare
7276a4e
to
ca602be
Compare
@nodejs/releasers just updated this PR. Now it iterates over open PRs in the private repo and adds them to the proposal branch -- with the metadata. If the PR doesn't contain CVE-ID metadata, it will ask to include it in the middle of the process. Could you please review it? |
ca602be
to
ad33378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A few details you might want to clean up before shipping (although I might just need clarification in a few places) 👍
Great work! Security releases are going to be much simpler 😊 🙏
ad33378
to
baf8494
Compare
🎉 |
I'm doing an experiment as part of my work on nodejs/security-wg#860 + upcoming security release.
I was talking with @BethGriggs and looks reasonable to generate the proposal PR for security releases using
git node release --security --prepare 19.6.1
.Currently,
git node land
doesn't work for the private repo, so the workflow is:Example:
Limitations that should be addressed in subsequent PRs: