-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Basic Lint Rules #70
Conversation
原則:只採納如 no-unreachable、no-unused-vars 之類運行時不會發現到的 rules,其他諸如 no-const-assign、no-invalid-regexp 之類運行時會發生錯誤的,以及如 array-bracket-newline、line-comment-position 等過份損害代碼自由度的則除外 |
本來想加一些 https://github.com/sindresorhus/eslint-plugin-unicorn 的 rules,但最後還是覺得太偏離 formatting,便棄用了 |
https://github.com/nk2028/tshet-uinh-examples/pull/63/files#r1855159531 tshet-uinh-examples/ayaka_v8.js Lines 444 to 446 in 159d3ae
|
# Publish | ||
- name: Install coscmd | ||
# Publish to NPM | ||
- if: github.event_name == 'release' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
這兩個用於發佈的 steps,寫成 jobs 會不會更好些?(雖然需要重新 checkout 和 build,但是在 Actions 頁面下就可以一眼看到它是僅測試了還是同時做了發佈的事
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加了 job name~
44989f2
to
2911b73
Compare
2911b73
to
cb06017
Compare
Adds minimal ESLint config with mostly stylistic rules to ensure code quality especially of incoming PRs.
I didn't employ a formatter for more flexibility with the snippets.
Additionally, derivers are now tested against all 音韻地位 to make sure they don't fail in any of them.