Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Darwin story for firefox and thunderbird #6303

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Jan 10, 2025

Description

  1. Allow to set null as package for thunderbird. (Common on Darwin when it's pulled from e.g. Homebrew. No need to build a dummy package.)
  2. Use -unwrapped packages for Darwin where wrapped versions are not supported in nixpkgs.
  3. While at it, fix example for thunderbird.package to list a package that actually exists (thunderbird-91 was removed a while ago).

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

This is useful when using Thunderbird managed externally, common
configuration on Darwin.
The wrapper derivation is not currently supported for the platform.
The wrapped version is not currently supported for the platform.
@github-actions github-actions bot added the mail label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant