Skip to content

Commit

Permalink
Support Typescript2 via npm
Browse files Browse the repository at this point in the history
  • Loading branch information
@jperl
jperl committed Aug 17, 2016
1 parent c4279ed commit b773a00
Show file tree
Hide file tree
Showing 2 changed files with 1,075 additions and 1,073 deletions.
Loading

4 comments on commit b773a00

@blakeembrey
Copy link

@blakeembrey blakeembrey commented on b773a00 Feb 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is wrong for both TypeScript and Typings, I left some additional notes in typings/registry#964 (comment).

@nitintutlani
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the ambient module declaration is now reverted.

@blakeembrey
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitintutlani Thanks! Let me know if there's anything I can help clarify for TypeScript 2.0 or help you with.

@blakeembrey
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitintutlani I didn't look before, but I just saw that it's still there:

typed-graphql/graphql.d.ts

Line 1167 in e068c96

declare module "graphql" {
.

Please sign in to comment.