Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with multiple versions #3

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

nikolai-laevskii
Copy link
Owner

@nikolai-laevskii nikolai-laevskii commented May 12, 2023

Description

  • Updated installers
  • Refactored DotnetCoreInstaller
  • Added LTS runtime installation before requested dotnet installation (see Detailed solution description)
  • Added E2E tests that check for the problem described in the issue

Detailed solution description

When dotnet is installed after usage of some other version, install script fails to override dotnet.exe as it appears to be used by a process. Workaround is to pass --skip-unversioned-files flag to the install script and avoid overriding this file altogether. However, to ensure better compatibility and to avoid vulnerability issues, LTS runtime is now installed first, providing up-to-date unversioned files (such as CLI) for further usage.

Failed checks
2 checks failed: it thinks that install scripts are not up-to-date for some reason, might be a problem with cache

Related issue:
actions#387

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant