Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Vitest to the project #40

Closed
nickytonline opened this issue Jan 14, 2024 · 11 comments · Fixed by #64
Closed

Feature: add Vitest to the project #40

nickytonline opened this issue Jan 14, 2024 · 11 comments · Fixed by #64
Assignees

Comments

@nickytonline
Copy link
Owner

nickytonline commented Jan 14, 2024

Add Vitest to the project, so that the starter kit has a testing framework in place.

Things to be done:

Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take".

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline added testing chore needs triage issue waiting to be triaged labels Jan 14, 2024
@nickytonline nickytonline changed the title Add Vitest to the project. Add Vitest to the project Jan 14, 2024
@nickytonline nickytonline changed the title Add Vitest to the project Feature: add Vitest to the project Jan 14, 2024
@adiati98
Copy link
Collaborator

adiati98 commented Jan 14, 2024

Love the idea of adding a test!
Just out of curiosity, @nickytonline, is there any reason to choose Vitest instead of Playwright or anything else?

Also, I always want to learn about test. I'm interested in working on this, but it might take me some time and some back and forth😅
So, if it does have a tight deadline, I'll pass it to someone else. 😊

@nickytonline
Copy link
Owner Author

Playwright is for end to end tests and component tests. Vitest is like Jest, for writing unit tests, and component tests (if not testing components in Playwright).

@jdwilkin4
Copy link
Contributor

So, if it does have a tight deadline, I'll pass it to someone else

It doesn't seem like there is a tight deadline here so you should work on it @adiati98 if you are interested 😄

@adiati98
Copy link
Collaborator

So, if it does have a tight deadline, I'll pass it to someone else

It doesn't seem like there is a tight deadline here so you should work on it @adiati98 if you are interested 😄

Thanks, @jdwilkin4! I'll .take it then 😄

Copy link

The issue you are trying to assign yourself is blocked until it can be triaged or by another label on the issue.

@adiati98 adiati98 removed the needs triage issue waiting to be triaged label Jan 19, 2024
@adiati98 adiati98 self-assigned this Jan 19, 2024
@nickytonline
Copy link
Owner Author

If you need any assistance, happy to help.

@adiati98
Copy link
Collaborator

If you need any assistance, happy to help.

I'll let you know! Thanks, Nick.

@adiati98
Copy link
Collaborator

adiati98 commented Feb 4, 2024

Hey @nickytonline @jdwilkin4 @Satoshi-Sh,

I've worked on this. And for some reason, I can't push my changes to remote repo. Below is the screenshot of the error.

error: failed to push some refs

I've tried git push -u origin feat/install-vites, git push -u upstream feat/install-vites, git pull --rebase upstream main, and git pull --rebase origin main. Nothing works.

Does anyone have similar case? I'm not sure what should I do here.

@nickytonline
Copy link
Owner Author

Did you fork the repository @adiati98? As a maintainer you don't need to. I see you're using upstream as your origin which is why I ask. This doesn't explain the erro though. That error usually means that feat/install-vites doesn't exist remotely, i.e. on GitHub.

I also see your using https instead of SSH. Again, I don't think that's the issue, but consider using SSH instead. See https://docs.github.com/en/authentication/connecting-to-github-with-ssh.

Worst case try creating a new branch and see if you end up with the same result.

@adiati98
Copy link
Collaborator

adiati98 commented Feb 4, 2024

Thanks, @nickytonline.
After debugging on Slack, I found out that I missed a letter in my branch name when I pushed it. 😅

Now all is good.

@adiati98 adiati98 mentioned this issue Feb 4, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants