-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add Vitest to the project #40
Comments
Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label. To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". For full info on how to contribute, please check out our contributors guide. |
Love the idea of adding a test! Also, I always want to learn about test. I'm interested in working on this, but it might take me some time and some back and forth😅 |
Playwright is for end to end tests and component tests. Vitest is like Jest, for writing unit tests, and component tests (if not testing components in Playwright). |
It doesn't seem like there is a tight deadline here so you should work on it @adiati98 if you are interested 😄 |
Thanks, @jdwilkin4! I'll .take it then 😄 |
The issue you are trying to assign yourself is blocked until it can be triaged or by another label on the issue. |
If you need any assistance, happy to help. |
I'll let you know! Thanks, Nick. |
Hey @nickytonline @jdwilkin4 @Satoshi-Sh, I've worked on this. And for some reason, I can't push my changes to remote repo. Below is the screenshot of the error. I've tried Does anyone have similar case? I'm not sure what should I do here. |
Did you fork the repository @adiati98? As a maintainer you don't need to. I see you're using I also see your using https instead of SSH. Again, I don't think that's the issue, but consider using SSH instead. See https://docs.github.com/en/authentication/connecting-to-github-with-ssh. Worst case try creating a new branch and see if you end up with the same result. |
Thanks, @nickytonline. Now all is good. |
Add Vitest to the project, so that the starter kit has a testing framework in place.
Things to be done:
astro-partykit-starter/package.json
Lines 42 to 45 in c8fcfeb
The text was updated successfully, but these errors were encountered: