Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in adding Playwright testing and Storybook? #39

Closed
jdwilkin4 opened this issue Jan 14, 2024 · 4 comments
Closed

Interest in adding Playwright testing and Storybook? #39

jdwilkin4 opened this issue Jan 14, 2024 · 4 comments
Labels
core team work enhancement New feature or request needs triage issue waiting to be triaged testing

Comments

@jdwilkin4
Copy link
Contributor

Is your feature request related to a problem? Please describe.

No, problem. Just an enhancement 😄

Describe the solution you'd like

Since this is a starter kit, it might be nice to include some testing examples with Playwright or something similar.
We could have a few tests for the chat app and other features.
We could also include Storybook might be nice to to test the individual UI components if we wanted to.

Describe alternatives you've considered

I have worked with Cypress in the past so that might be a nice option too.

Additional context

@jdwilkin4 jdwilkin4 added the needs triage issue waiting to be triaged label Jan 14, 2024
Copy link

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take".

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline added the enhancement New feature or request label Jan 14, 2024
@nickytonline
Copy link
Owner

nickytonline commented Jan 14, 2024

Yeah, that's a great idea @jdwilkin4! We can also add Vitest to the project. I create #40 to start that discussion.

Thoughts @5hraddha, @Satoshi-Sh, @adiati98, @Terieyenike?

@Terieyenike
Copy link

Adding tests to apps is a great idea. I've worked with Jest.

@nickytonline
Copy link
Owner

It sounds like we'll be going forward with this, but I'll wait for the rest of the team to chime in. If we move forward, this should be two separate issues. One for Storybook and one for Playwright.

Repository owner locked and limited conversation to collaborators Jan 14, 2024
@nickytonline nickytonline converted this issue into discussion #41 Jan 14, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
core team work enhancement New feature or request needs triage issue waiting to be triaged testing
Projects
None yet
Development

No branches or pull requests

3 participants