Replace onTab for keyBindingFn #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
· onTab is deprecated and after key pressing it, it doesn't indent the text. · Indent line on selection adding spaces at the start of the line.
|
I am not sure what the test failure indicates. Is this hard to fix? I would really like to get rid of the warning in my console.. |
|
@kristiandupont The error in the test is due to my lack of permissions in the repository. I hope the author has time to take a look. 🤔 |
|
@ngs sorry to bother you, just wondering if this might be simple to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
· Solves onTab warnings. onTab is deprecated and after key pressing it, it doesn't indent the text.
· Solves line indention on selecting text adding spaces at the start of the line.