Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure sbindir is proper value for RPM #1560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Feb 14, 2025

Starting with Fedora 42 /usr/sbin is no more used, so default value is no more suitable

So %{_sbindir} is defined as /usr/bin

@thresheek
Copy link
Member

Hello! Thank you for your contribution!

LGTM except for a few minor nits:

  • commit message should be something like:
    Packaging: Ensure sbindir is properly set on newer Fedora (42+)

  • probably squash into one commit?

  • shall we use a %{__sed} macro instead of a direct invocation? I'm not really following the contemporary stance on using macros vs directly calling executables in the specs, but at least it would be inline with pretty much all the other calls in the spec file.

@remicollet
Copy link
Contributor Author

shall we use a %{__sed}

No.

@remicollet
Copy link
Contributor Author

Notice: this is only the mandatory change required to build F42 package

BTW current spec file is outdated

Especially for

  • systemd
  • sysusers

Switch to systemd packaging work for all Fedora and EL >= 8
Switch to sysusers packaging work for all Fedora and EL >= 8, and is mandatory for F42

Ex recent change done for my repo
https://git.remirepo.net/cgit/rpms/unit.git/commit/?id=22a5372cf24b0d2e26aa74948b2e797ac880dfc3

@thresheek thresheek self-assigned this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants