Replace punycode dependency with string iteration #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The spread operator has been available since Node 5.0.0, and iterates strings over their code points (not code units), as expected here. There’s no need to use the punycode library for this.
Code quality
package.json
file. Beware to use the same format than for the author field for the entries so that you'll get a mention in theREADME.md
with a link to your website.License
To get your contribution merged, you must check the following.
Join
My NPM username: andersk