Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace punycode dependency with string iteration #173

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 7, 2024

Proposed changes

The spread operator has been available since Node 5.0.0, and iterates strings over their code points (not code units), as expected here. There’s no need to use the punycode library for this.

Code quality

  • I made some tests for my changes
    • This is already covered by tests
  • I added my name in the contributors field of the package.json file. Beware to use the same format than for the author field for the entries so that you'll get a mention in the README.md with a link to your website.

License

To get your contribution merged, you must check the following.

  • I read the project license in the LICENSE file
  • I agree with publishing under this project license

Join

  • I wish to join the core team
  • I agree that with great powers comes responsibilities
  • I'm a nice person

My NPM username: andersk

The spread operator has been available since Node 5.0.0, and iterates
strings over their code points (not code units), as expected here.
There’s no need to use the punycode library for this.

Signed-off-by: Anders Kaseorg <[email protected]>
@nfroidure nfroidure merged commit 9bb1cff into nfroidure:main Nov 7, 2024
1 check passed
@nfroidure
Copy link
Owner

nfroidure commented Nov 7, 2024

Published under [email protected] . Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants