Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 354 #358

Closed
wants to merge 1 commit into from
Closed

Issue 354 #358

wants to merge 1 commit into from

Conversation

lpantano
Copy link
Contributor

Addressing the issue with Blat containers, should we update them ?

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @lpantano,

It looks like this pull-request is has been made against the nf-core/smrnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/smrnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@lpantano lpantano changed the base branch from master to dev June 28, 2024 21:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit c00d321

+| ✅ 208 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   4 tests had warnings |!
-| ❌   5 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - .github/workflows/linting_comment.yml does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • base_config - conf/base.config contains withName:CUSTOM_DUMPSOFTWAREVERSIONS, but the corresponding process is not present in any of the Nextflow scripts.
  • modules_config - conf/modules.config contains withName:CUSTOM_DUMPSOFTWAREVERSIONS, but the corresponding process is not present in any of the Nextflow scripts.

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-28 21:20:17

@apeltzer
Copy link
Member

apeltzer commented Aug 8, 2024

x-ref #368 - we shoudl even consider either adding BLAT to nf-core/modules and importing from there or updating the container & using seqera containers now that this is available. That should improve the situation I hope :)

Nicolas/Anabella can work on this 👍🏻

@lpantano
Copy link
Contributor Author

lpantano commented Aug 9, 2024

thanks, then we close this, right?

@apeltzer
Copy link
Member

We can I think 👍

@lpantano lpantano closed this Aug 16, 2024
@apeltzer apeltzer deleted the issue-354 branch September 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpantano @apeltzer