Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-core template 3.2.0 #101

Merged
merged 15 commits into from
Jan 31, 2025
Merged

nf-core template 3.2.0 #101

merged 15 commits into from
Jan 31, 2025

Conversation

nvnieuwk
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • Parameters Documentation is updated with nf-core schema docs --format markdown --output docs/parameters.md --force
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk nvnieuwk requested review from matthdsm and mvheetve January 31, 2025 12:46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't think this should be here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah crap, stupid template merge :p

@@ -614,6 +614,7 @@ process {
withName: 'MULTIQC' {
ext.args = { params.multiqc_title ? "--title \"$params.multiqc_title\"" : '' }
publishDir = [
path: { "${params.outdir}/multiqc" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the same line twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch :p that snuck in during merge conflict resolving

Copy link
Collaborator

@mvheetve mvheetve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, more than I expected tho...

@nvnieuwk nvnieuwk merged commit b208ea0 into dev Jan 31, 2025
38 checks passed
@nvnieuwk nvnieuwk deleted the template/3.2.0 branch January 31, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants