-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nf-core template 3.2.0 #101
Conversation
modules/nf-core/fastqc/main.nf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think this should be here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah crap, stupid template merge :p
conf/modules.config
Outdated
@@ -614,6 +614,7 @@ process { | |||
withName: 'MULTIQC' { | |||
ext.args = { params.multiqc_title ? "--title \"$params.multiqc_title\"" : '' } | |||
publishDir = [ | |||
path: { "${params.outdir}/multiqc" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the same line twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch :p that snuck in during merge conflict resolving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, more than I expected tho...
PR checklist
nf-core lint
).nf-test test
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.nf-core schema docs --format markdown --output docs/parameters.md --force
CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).