Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align: trim down print statements for insertions #1737

Open
joverlee521 opened this issue Jan 22, 2025 · 1 comment
Open

align: trim down print statements for insertions #1737

joverlee521 opened this issue Jan 22, 2025 · 1 comment
Labels
proposal Proposals that warrant further discussion

Comments

@joverlee521
Copy link
Contributor

Context

I noticed that augur align prints insertions to stdout, which can potentially lead to workflow logs being flooded with long insertion sequences as noted in nextstrain/hmpv#8. I think we can trim down these print statements since the same insertions are output to a file. It's not entirely clear to me from reading #449 why insertions need to be print to stdout in addition to the output CSV file.

Possible solution

  1. Remove the print statements entirely
  2. Only print to stdout for debugging i.e. when the command is run with the --debug flag
  3. Keep the print statements because of (?) and always redirect stdout from augur align to a log file in workflows.
@joverlee521 joverlee521 added the proposal Proposals that warrant further discussion label Jan 22, 2025
@jameshadfield
Copy link
Member

That was a long time ago! No reason for them to go to stdout as far as I can see. Option 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposals that warrant further discussion
Projects
None yet
Development

No branches or pull requests

2 participants