Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter noise for function _square_dimond #361

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

saivythik
Copy link
Contributor

Reference issue

Closes- #358

Type of change

Bug

What does this implement/fix?

Parameter "noise" for function _square_diamond()
in the _square_diamond
the Parameter x
before
x = u * np.cos(period) + v * np.sin(period) + 0.05 * p * gauss_noise
After
x = u * np.cos(period) + v * np.sin(period) + 0.05 * p * gauss_noise * noise
now x has the expected output

Additional information

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0859c71) 96.73% compared to head (cd434d1) 96.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files          84       84           
  Lines        3732     3732           
=======================================
  Hits         3610     3610           
  Misses        122      122           
Impacted Files Coverage Δ
hyppo/tools/indep_sim.py 99.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sampan501 sampan501 merged commit f1bcf3f into neurodata:main Apr 3, 2023
@sampan501 sampan501 added bug Something isn't working documentation Improvements or additions to documentation labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants