Mlo 133 create admission controller #906
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
parikls
force-pushed
the
MLO-133-create-admission-controller
branch
from
e7451fe to
2767261
Compare
| LABEL_APOLO_ORG_NAME = "platform.apolo.us/org" | ||
| LABEL_APOLO_PROJECT_NAME = "platform.apolo.us/project" | ||
| LABEL_APOLO_STORAGE_MOUNT_PATH = "platform.apolo.us/storage/mountPath" | ||
| LABEL_APOLO_STORAGE_HOST_PATH = "platform.apolo.us/storage/hostPath" |
There was a problem hiding this comment.
@zubenkoivan this supposed to be a storage URL, e.g., storage://org/proj/path/to/dir. Maybe hostPath label name is not the best option here?
There was a problem hiding this comment.
Can we use a single annotation to pass storage config? we can put json object there
| @@ -55,6 +55,16 @@ spec: | |||
| {{- end }} | |||
| env: | |||
| {{- include "platformStorage.env" . | nindent 10 }} | |||
| - name: NP_STORAGE_API_K8S_API_URL | |||
There was a problem hiding this comment.
I think main api doesn't use kube client
| LABEL_APOLO_ORG_NAME = "platform.apolo.us/org" | ||
| LABEL_APOLO_PROJECT_NAME = "platform.apolo.us/project" | ||
| LABEL_APOLO_STORAGE_MOUNT_PATH = "platform.apolo.us/storage/mountPath" | ||
| LABEL_APOLO_STORAGE_HOST_PATH = "platform.apolo.us/storage/hostPath" |
There was a problem hiding this comment.
Can we use a single annotation to pass storage config? we can put json object there
| ca_data = Path(ca_path).read_text() if ca_path else None | ||
|
|
||
| token_path = self._environ.get("NP_STORAGE_API_K8S_TOKEN_PATH") | ||
| token = Path(token_path).read_text() if token_path else None |
There was a problem hiding this comment.
Shouldn't apolo-kube-client read ca_data and token from files?
No description provided.