Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gar artifacts urls #907

Merged
merged 15 commits into from
Feb 13, 2025
Merged

support gar artifacts urls #907

merged 15 commits into from
Feb 13, 2025

Conversation

petrucci89
Copy link
Contributor

No description provided.

Copy link

linear bot commented Feb 8, 2025

@petrucci89 petrucci89 changed the title support artifacts urls support gar artifacts urls Feb 8, 2025
@github-actions github-actions bot added the review-ready PR is ready for the review label Feb 8, 2025
Copy link

sentry-io bot commented Feb 8, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: platform_registry_api/api.py

Function Unhandled Issue
_convert_location_header ValueError: 'artifacts-uploads/namespaces/development-421920/repositories/platform-registry-dev' does not mat... ...
Event Count: 27
_convert_location_header ValueError: unexpected path in a registry URL: /artifacts-downloads/namespaces/development-421920/repositorie... ...
Event Count: 26
from_url ValueError: unexpected path in a registry URL: https://registry.api.dev.apolo.us/artifacts-uploads/namespaces... ...
Event Count: 26

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

@zubenkoivan zubenkoivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@petrucci89 petrucci89 merged commit f090784 into master Feb 13, 2025
13 checks passed
@petrucci89 petrucci89 deleted the ENG-569-artifacts branch February 13, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready PR is ready for the review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants