fix linter issues

Signed-off-by: Denis Tingaikin <[email protected]>

.golangci.yml

@@ -120,7 +120,6 @@ linters-settings:
       - unnamedResult
       - unnecessaryBlock
       - underef
-      - unlambda
       - unslice
       - valSwap
       - weakCond
@@ -133,7 +132,7 @@ linters:
     - goheader
     - bodyclose
     - deadcode
-    - depguard
+   # - depguard
     - dogsled
     - dupl
     - errcheck
@@ -302,6 +301,3 @@ issues:
       linters:
         - interfacer
       text: "`rawSrv` can be `github.com/networkservicemesh/sdk/pkg/networkservice/common/monitor.EventConsumer`"
-    - path: pkg/registry/chains/proxydns/.*_test.go
-      linters:
-        - unlambda

pkg/registry/chains/proxydns/server_ns_test.go

@@ -93,8 +93,8 @@ func TestInterdomainNetworkServiceRegistryWithDifferentDNSScheme(t *testing.T) {
 	dnsServer.DeleteSRVEntry(dnsresolve.DefaultNsmgrProxyService, domain2.Name)
 	dnsServer.DeleteSRVEntry(dnsresolve.DefaultRegistryService, domain2.Name)
 
-	dnsServer.AddSRVEntry("example.com", "nsmgr-proxy2", domain2.NSMgrProxy.URL)
-	dnsServer.AddSRVEntry("example.com", "registry2", domain2.Registry.URL)
+	require.NoError(t, dnsServer.AddSRVEntry("example.com", "nsmgr-proxy2", domain2.NSMgrProxy.URL))
+	require.NoError(t, dnsServer.AddSRVEntry("example.com", "registry2", domain2.Registry.URL))
 
 	client1 := registryclient.NewNetworkServiceRegistryClient(ctx,
 		registryclient.WithDialOptions(grpc.WithTransportCredentials(insecure.NewCredentials())),

pkg/registry/chains/proxydns/server_nse_test.go

@@ -94,8 +94,8 @@ func TestInterdomainNetworkServiceEndpointRegistryWithDifferentDNSScheme(t *test
 	dnsServer.DeleteSRVEntry(dnsresolve.DefaultNsmgrProxyService, domain2.Name)
 	dnsServer.DeleteSRVEntry(dnsresolve.DefaultRegistryService, domain2.Name)
 
-	dnsServer.AddSRVEntry("example.com", "nsmgr-proxy2", domain2.NSMgrProxy.URL)
-	dnsServer.AddSRVEntry("example.com", "registry2", domain2.Registry.URL)
+	require.NoError(t, dnsServer.AddSRVEntry("example.com", "nsmgr-proxy2", domain2.NSMgrProxy.URL))
+	require.NoError(t, dnsServer.AddSRVEntry("example.com", "registry2", domain2.Registry.URL))
 
 	expirationTime := timestamppb.New(time.Now().Add(time.Hour))
 

pkg/registry/common/dnsresolve/ns_server_test.go

@@ -88,7 +88,7 @@ func TestDNSResolve_LoopUsecase(t *testing.T) {
 	u, err := url.Parse("tcp://127.0.0.1:80")
 	require.NoError(t, err)
 
-	require.NoError(t, sandbox.AddSRVEntry(resolver, "domain1", srv, u))
+	require.NoError(t, resolver.AddSRVEntry("domain1", srv, u))
 
 	s := dnsresolve.NewNetworkServiceRegistryServer(
 		dnsresolve.WithRegistryService(srv),