Node: fix SONiC detection, and bug fix #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newer SONiC versions have a different string to match to extract the version. Add that. Plus, fix a bug in extracting the version during device init. Signed-off-by: Dinesh Dutt <[email protected]>
LucaNicosia
approved these changes
Jan 10, 2024
AndryNick98
approved these changes
Jan 10, 2024
claudious96
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer SONiC versions have a different string to match to extract the version. Add that. Plus, fix a bug in extracting the version during device init.
Set
developas target branch of this PR (delete this line before issuing the PR)Description
Fix detection of SONiC devices and version extraction of newer SONiC versions.
Type of change
Please delete options that are not relevant.
New Behavior
SONiC newer versions are correctly detected as SONiC, and version correctly extracted for all versions, old and new.
...
Proposed Release Note Entry
Double Check
developbranch.developbranch.--signoffapplied