Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper compare interface name and interface ips #55

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

leoparente
Copy link
Contributor

@leoparente leoparente commented Jan 17, 2025

Proper compare interface name and interface ips

Code Updates:

  • Fixed a bug in translate_interface_ips to correctly compare interface names using == instead of in. (device-discovery/device_discovery/translate.py)

Renaming Components:

  • Updated the README to reflect the new name "Orb Device Discovery Backend" and corrected the version display description. (device-discovery/README.md)
  • Changed the namespace and entry point descriptions from "Orb Discovery" to "Device Discovery" in the __init__.py and main.py files. (device-discovery/device_discovery/__init__.py, device-discovery/device_discovery/main.py) [1] [2] [3]
  • Renamed policy manager, models, and runner descriptions to "Device Discovery." (device-discovery/device_discovery/policy/manager.py, device-discovery/device_discovery/policy/models.py, device-discovery/device_discovery/policy/runner.py) [1] [2] [3]
  • Updated the server description to "Device Discovery Server." (device-discovery/device_discovery/server.py)

Test Enhancements:

  • Added a new interface to the sample device info and adjusted the sample interface info to include the new interface. (device-discovery/tests/test_translate.py) [1] [2] [3]
  • Updated test cases to verify the translation of the new interface data. (device-discovery/tests/test_translate.py) [1] [2]

@leoparente leoparente self-assigned this Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
device_discovery
   discovery.py35294%91–94
   main.py32294%90, 96
   server.py68494%33–35, 128, 131
   version.py7186%14
device_discovery/policy
   manager.py41295%36–37
   runner.py66198%49
TOTAL4011297% 

Tests Skipped Failures Errors Time
49 0 💤 0 ❌ 0 🔥 6.053s ⏱️

@leoparente leoparente merged commit 45c4213 into develop Jan 17, 2025
7 checks passed
@leoparente leoparente deleted the fix/OBS-689-device-discovery-duplicated-ip branch January 17, 2025 14:48
Copy link

🎉 This PR is included in version 0.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: duplicated interface IPs on interfaces containing names of other interfaces with IPs defined
2 participants