Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add standard namespace and metadata #192

Merged
merged 2 commits into from
May 2, 2024
Merged

Add standard namespace and metadata #192

merged 2 commits into from
May 2, 2024

Conversation

LeoColomb
Copy link
Member

@LeoColomb LeoColomb commented May 2, 2024 •
edited
Loading

Using Bitnami common helpers from #184 to provide the following:

  • Correctly namespaced entities
  • Labels and annotations with proper merging function (to avoid duplications and errors)
  • More validations around metadata (length of names is crucial, as much as other structure)

@LeoColomb LeoColomb marked this pull request as draft May 2, 2024 16:41
@LeoColomb LeoColomb marked this pull request as ready for review May 2, 2024 17:09
@RangerRick
Copy link
Contributor

Lost of changes, but hey, we have tests now, and everything checks out. Ship it! :shipit:

@RangerRick RangerRick merged commit a4063b6 into netbox-community:develop May 2, 2024
8 checks passed
@LeoColomb LeoColomb deleted the feat/namespace-labels-anno branch May 2, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoColomb @RangerRick