Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SchemaFactory trigger an error when a schema doesn't have the @Schema decorator #1702

Closed
wants to merge 4 commits into from

Conversation

DanielSuhett
Copy link

@DanielSuhett DanielSuhett commented Mar 11, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

#1697

Issue Number: 1697

What is the new behavior?

When you call SchemaFactory.createForClass without a @Schema throw a new error.
Tests to check update with Schema.
Not extends anymore the mongoose Document because he overwrite the @Schema decorator

Does this PR introduce a breaking change?

  • Yes
  • No

extends mongoose Document trigger throw an error because the @Schema decorator don't run with it.

Other information

@DanielSuhett DanielSuhett deleted the fix-schema-factory branch March 14, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant