Corrected unit of q_stc to pA in gif_psc_exp

[Laxmi-gupta]

This is my first contribution, and I noticed that the adaptive current q_stc was mentioned in nA, but it should be in pA.

I made two changes:

Updated the comment to correctly state pA instead of nA.
Converted the value by multiplying it by 1000 to properly reflect pA in the calculation.

Changes made in:
File: models/gif_psc_exp.cpp
Line: 357

I haven’t tested this yet since it’s my first issue, but I followed the logic and made the necessary correction.

[clinssen]

Hi, thank you for your contribution!

You mention that q_stc "should be" in pA. Could you say why this is so? Defining it in pA and multiplying it with a factor 1E3 is equivalent and so does not really fix a bug per se; it is a matter of convention (which could certainly be a legitimate reason, just wondering if you have a particular reason or reference for this). Cheers!

By the way, to run the testsuite locally, you can run make installcheck from the build directory.

[Laxmi-gupta]

Thank you for your feedback and for pointing out the equivalence between defining q_stc in nA and pA. You're absolutely correct that mathematically, defining q_stc in nA and scaling it by 1e3 is equivalent to defining it directly in pA. However, this change is primarily rooted in consistency and clarity within the model.
Thank you also for the tip about running the testsuite locally with make installcheck—I’ll definitely make use of that.

[clinssen]

Could you say in more detail what the consistency is between? There are many variants of the "gif" model that also define q_stc in nA, so to keep it consistent, they would all need to be changed. Could you give a reference to an equation or parameters table in the literature (like to the original publication of the model) where the value is given in pA? Much obliged!