Allow passing OpenMP root directory to -Dwith-openmp #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
heplesser
requested review from
lekshmideepu and
gtrensch
and removed request for
lekshmideepu
gtrensch
approved these changes
Aug 29, 2024
|
@JoshuaBoettcher I have now added you as a reviewer and am looking forward to your comments. |
|
Pull request automatically marked stale! |
github-actions
bot
added
the
stale
terhorstd
requested review from
pnbabu
and removed request for
JoshuaBoettcher
pnbabu
reviewed
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the handling of
-Dwith-openmpin line with MPI and other libraries according to modern CMake practice, so that the root directory of thelibompinstallation can be passed as an argument. In existing code, and argument different fromONorOFFis actually handled incorrectly. Also update related variable names to include lowercase letters, as is modern CMake practice, see CMP0144.Furthermore, in the cmake summary, results for threading and MPI are now reported next to each other early in the report.