Add parameter json to .seq/.dat converter tool #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from argparse import ArgumentParser | ||
| from fprime_gds.common.loaders.prm_json_loader import PrmJsonLoader | ||
| from fprime_gds.common.templates.prm_template import PrmTemplate | ||
| from fprime.common.models.serialize.type_base import BaseType |
Check notice
Code scanning / CodeQL
Unused import Note
|
@zimri-leisher do you want to fix the spelling, or shall I? |
|
If there are no other comments, I will fix the spelling. However, I would prefer to do that after doing other code review things, so I only have to do it once. |
|
Agreed. We'll review and get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
See nasa/fprime#3163
Rationale
Testing/Review Recommendations
Attempt to use on Ref app.
Future Work