Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move AIParametersParser to n8n-workflow (no-changelog) #12671

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

CharlieKolb
Copy link
Contributor

@CharlieKolb CharlieKolb commented Jan 17, 2025

Summary

Extract stateless parsing utils to the shared workflow package.

We'll need this of this in the front end, and we'll be able to replace duplication in the ToolWorkflow in a follow up as well.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3112/move-aiargumentparser-to-n8n-workflow

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ode-execution-context/utils/create-node-as-tool.ts 96.00% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@CharlieKolb CharlieKolb marked this pull request as ready for review January 27, 2025 09:12
@CharlieKolb CharlieKolb changed the title chore: Move AIArgumentParser to n8n-workflow (no-changelog) chore: Move AIParametersParser to n8n-workflow (no-changelog) Jan 28, 2025
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jan 28, 2025

n8n    Run #8981

Run Properties:  status check passed Passed #8981  •  git commit 78b731b95d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Project n8n
Branch Review ADO-3112
Run status status check passed Passed #8981
Run duration 04m 16s
Commit git commit 78b731b95d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
Committer Charlie Kolb
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

@CharlieKolb CharlieKolb merged commit 13652c5 into master Jan 28, 2025
39 checks passed
@CharlieKolb CharlieKolb deleted the ADO-3112 branch January 28, 2025 09:47
@janober
Copy link
Member

janober commented Jan 29, 2025

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants