-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move AIParametersParser to n8n-workflow (no-changelog) #12671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Jan 17, 2025
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
CharlieKolb
changed the title
chore: Move AIArgumentParser to n8n-workflow (no-changelog)
chore: Move AIParametersParser to n8n-workflow (no-changelog)
Jan 28, 2025
OlegIvaniv
approved these changes
Jan 28, 2025
✅ All Cypress E2E specs passed |
n8n Run #8981
Run Properties:
|
Project |
n8n
|
Branch Review |
ADO-3112
|
Run status |
Passed #8981
|
Run duration | 04m 16s |
Commit |
78b731b95d: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 CharlieKolb 🗃️ e2e/*
|
Committer | Charlie Kolb |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
5
|
Skipped |
0
|
Passing |
430
|
View all changes introduced in this branch ↗︎ |
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extract stateless parsing utils to the shared
workflow
package.We'll need this of this in the front end, and we'll be able to replace duplication in the ToolWorkflow in a follow up as well.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/ADO-3112/move-aiargumentparser-to-n8n-workflow
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)