Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ConvertAPI cred only node #12663

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Jan 17, 2025

Summary

ConvertAPI Cred only node for DevRel.

An account can be created here: https://www.convertapi.com/ with free credits for any testing.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-2252/cred-only-node-convertapi

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill requested a review from elsmr January 17, 2025 09:56
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/nodes-base/credentials/ConvertApi.credentials.ts 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

elsmr
elsmr previously approved these changes Jan 20, 2025
packages/nodes-base/credentials/ConvertApi.credentials.ts Outdated Show resolved Hide resolved
Copy link

cypress bot commented Jan 20, 2025

n8n    Run #8835

Run Properties:  status check passed Passed #8835  •  git commit 17c5232782: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Project n8n
Branch Review node-2252-cred-only-node-convertapi
Run status status check passed Passed #8835
Run duration 04m 55s
Commit git commit 17c5232782: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Joffcom 🗃️ e2e/*
Committer Jonathan Bennetts
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 489
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants