Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Polish team export #268

Merged
merged 1 commit into from
Feb 3, 2025
Merged

[tools] Polish team export #268

merged 1 commit into from
Feb 3, 2025

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 2, 2025

Comes alongside of mui/material-ui#45165. Now, we should be able to have a script that automatically pull the data from HiBob and store it in git to be displayable. This scale.

Preview: https://mui-public-tools-public-pr-268.onrender.com/prod/pages/muicomabout

@oliviertassinari oliviertassinari temporarily deployed to polish-team-export - mui-public-tools-public PR #268 February 2, 2025 13:00 — with Render Destroyed
'address.city',
'address.customColumns.column_1738498855264',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid leaking the city when the info is sensitive, or too unknown, or else.

@oliviertassinari oliviertassinari merged commit 9c72f14 into master Feb 3, 2025
5 checks passed
@oliviertassinari oliviertassinari deleted the polish-team-export branch February 3, 2025 15:28
@Janpot
Copy link
Member

Janpot commented Feb 3, 2025

Is the main reason it's in toolpad is so we don't have to distribute a secret amongst users of the script? Perhaps this would also make sense as a github action called from a script: download from hibob, store in artifact, download artifact.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Feb 5, 2025

Is the main reason it's in toolpad is so we don't have to distribute a secret amongst users of the script?

@Janpot Keeping the API key private is a must-have (the API key itself gives access to a very limited scope, but I don't want people's addresses to be more public than the scope of our organization).

Another reason is that it seems easier to scan data in a data grid like format that in JSON or cards. We link this in https://www.notion.so/mui-org/XXX-s-onboarding-c980eff81a1e405bb36476d0cf22b5e6?pvs=4#45f843d779d042a2ad8da6d877dfb887.

Perhaps this would also make sense as a github action called from a script: download from hibob, store in artifact, download artifact.

Yeah, this could work. I don't see a pressing problem this would solve, but yeah a viable option. We could also move this to be a simple API call from an express server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: tools Toolpad support apps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants