-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "native" wayland clipboard backend and several related properties #15704
Open
na-na-hi
wants to merge
10
commits into
mpv-player:master
Choose a base branch
from
na-na-hi:wayland-clipboard
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+529
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used for logging, and further creation of log contexts can use the parenting feature instead, so there is no need to store it.
This adds clipboard backend names to backend-specific logs, e.g. clipboard/vo.
This adds a "native" Wayland clipboard backend based on the wlr-data-control-unstable-v1/ext-data-control-v1 protocol. This backend overcomes the limitation of the VO (Wayland core protocol) backend, and does not require the presence of the VO window to receive clipboard updates. This backend also supports primary selection if supported by the compositor. The backend runs in a separate thread, so clipboard reading does not stall the player like the VO backend.
This property contains the text in the primary selection.
Some platforms like Wayland may have support for multiple backends, so add this function to make it possible to determine the current active backend.
Useful to know which clipboard backend is active.
This backend does not require the window focus quirk handling, and also supports primary selection.
Haven't looked too closely, but mpv doesn't use |
Download the artifacts for this pull request: |
na-na-hi
force-pushed
the
wayland-clipboard
branch
3 times, most recently
from
January 18, 2025 08:13
9fdd20d
to
2fc1ad3
Compare
This should probably behave like c9412b4 for consistency with the vo backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a "native" Wayland clipboard backend based on the
wlr-data-control-unstable-v1/ext-data-control-v1
protocol.This backend overcomes the limitation of the VO (Wayland core protocol) backend, and does not require the presence of the VO window to receive clipboard updates. The backend runs in a separate thread, so clipboard reading does not stall the player like the VO backend.
This backend also supports primary selection if supported by the compositor. The
clipboard/text-primary
property is added for primary selection text.Also add
current-clipboard-backend
property to make the current backend detectable, and update console.lua to use the new backend if available.