bug(auth): Typescript not checking all files #17940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
force-pushed
the
fix-auth-tsconfig
branch
2 times, most recently
from
9acff8a
to
f9451ae
Compare
pdehaan
reviewed
Oct 31, 2024
| @@ -365,7 +365,8 @@ describe('CustomerPlanMover', () => { | |||
| it("returns false if the customer does not have a price that's excluded", () => { | |||
| const result = customerPlanMover.isCustomerExcluded([ | |||
| { | |||
| ...subscription1, | |||
| // TODO: Either provide full mock, or reduce type required isCustomerExcluded | |||
There was a problem hiding this comment.
nit: should we file a bug for this so we track/bury it in the backlog?
There was a problem hiding this comment.
We do this as unknown as Type pattern quite a bit. Maybe it's fine. I'll let @StaberindeZA make the call.
Comment on lines
17
to
24
| "bin/**/*.js", | ||
| "bin/**/*.ts", | ||
| "lib/**/*.ts", | ||
| "lib/**/*.js", | ||
| "scripts/*.ts", | ||
| "scripts/*.js", | ||
| "test/**/*.ts", | ||
| "test/**/*.js" |
There was a problem hiding this comment.
Confirmed no weird .jsx or .tsx files.
git ls-files packages/fxa-auth-server/(bin|lib|scripts|test)/ | grep -Eo "\.[a-z]+$" | sort | uniq -c | sort -rn
343 .js
197 .ts
139 .json
85 .txt
77 .mjml
76 .ftl
8 .scss
...There was a problem hiding this comment.
Thanks for checking. Server so, hopefully not!
dschom
force-pushed
the
fix-auth-tsconfig
branch
2 times, most recently
from
8cfef67
to
4d20a37
Compare
StaberindeZA
reviewed
Nov 4, 2024
|
@StaberindeZA BTW, looks we we are hitting OOMs in CI tests. If you got any suggestions let me know. |
dschom
force-pushed
the
fix-auth-tsconfig
branch
from
4d20a37
to
2f9ebd7
Compare
StaberindeZA
reviewed
Nov 4, 2024
dschom
force-pushed
the
fix-auth-tsconfig
branch
3 times, most recently
from
25e249e
to
42e15ad
Compare
Because: - While working on FXA-10460, I noticed that auth-server wasn't actually targeting all typescript files for compilation. This commit: - Targets all files - Fixes ensuing errors
dschom
force-pushed
the
fix-auth-tsconfig
branch
from
42e15ad
to
e3e2ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-10676
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
This is a fast follow to #17938. Also it's good to note that make this PR reasonable in size,
noImplicitAnywas set to false. We can address this at a later point in time. There were enough of these errors that it didn't make sense to fix them here, and to fix them properly actual types should be tracked down.