Merge pull request #17303 from mozilla/FXA-10027

feat(newsletters): Update first checkbox slug and copy
mozilla · Jul 31, 2024 · 79dd9e0 · 79dd9e0
2 parents 8b49aeb + 1ba414f
commit 79dd9e0
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 15 deletions.
diff --git a/packages/fxa-settings/src/components/ChooseNewsletters/en.ftl b/packages/fxa-settings/src/components/ChooseNewsletters/en.ftl
@@ -4,8 +4,8 @@
 # Prompt above a checklist of newsletters
 choose-newsletters-prompt-2 = Get more from { -brand-mozilla }:
 # Newsletter checklist item
-choose-newsletters-option-security-privacy =
-  .label = Security & privacy news and updates
+choose-newsletters-option-latest-news =
+  .label = Get our latest news and product updates
 # Newsletter checklist item
 choose-newsletters-option-test-pilot =
   .label = Early access to test new products

diff --git a/packages/fxa-settings/src/components/ChooseNewsletters/newsletters.ts b/packages/fxa-settings/src/components/ChooseNewsletters/newsletters.ts
@@ -16,18 +16,18 @@ export type Newsletter = {
 
 export const newsletters: Newsletter[] = [
   {
-    label: 'Security & privacy news and updates',
-    slug: ['security-privacy-news', 'mozilla-accounts'],
-    ftlId: 'choose-newsletters-option-security-privacy',
-  },
-  {
-    label: 'Early access to test new products',
-    slug: ['test-pilot'],
-    ftlId: 'choose-newsletters-option-test-pilot',
+    label: 'Get our latest news and product updates',
+    slug: ['mozilla-and-you', 'mozilla-accounts'],
+    ftlId: 'choose-newsletters-option-latest-news',
   },
   {
     label: 'Action alerts to reclaim the internet',
     slug: ['mozilla-foundation'],
     ftlId: 'choose-newsletters-option-reclaim-the-internet',
   },
+  {
+    label: 'Early access to test new products',
+    slug: ['test-pilot'],
+    ftlId: 'choose-newsletters-option-test-pilot',
+  },
 ];
diff --git a/packages/fxa-settings/src/pages/Signup/index.test.tsx b/packages/fxa-settings/src/pages/Signup/index.test.tsx
@@ -459,10 +459,10 @@ describe('Signup page', () => {
               // we expect three newsletter options, but 4 slugs should be passed
               // because the first newsletter checkbox subscribes the user to 2 newsletters
               selectedNewsletterSlugs: [
-                'security-privacy-news',
+                'mozilla-and-you',
                 'mozilla-accounts',
-                'test-pilot',
                 'mozilla-foundation',
+                'test-pilot',
               ],
               unwrapBKey: MOCK_UNWRAP_BKEY,
             },

diff --git a/packages/fxa-settings/src/pages/Signup/index.tsx b/packages/fxa-settings/src/pages/Signup/index.tsx
@@ -273,11 +273,10 @@ export const Signup = ({
           GleanMetrics.registration.marketing({
             standard: {
               marketing: {
+                news: selectedNewsletterSlugs.indexOf('mozilla-and-you') >= 0,
                 take_action:
-                  selectedNewsletterSlugs.indexOf('security-privacy-news') >= 0,
-                testing: selectedNewsletterSlugs.indexOf('test-pilot') >= 0,
-                news:
                   selectedNewsletterSlugs.indexOf('mozilla-foundation') >= 0,
+                testing: selectedNewsletterSlugs.indexOf('test-pilot') >= 0,
               },
             },
           });