Skip to content

Commit

Permalink
change from clients_first_seen_v2 to v3 (#6651)
Browse files Browse the repository at this point in the history
  • Loading branch information
@Marlene-M-Hirose
Marlene-M-Hirose authored Dec 11, 2024
1 parent 8e6def5 commit 9814402
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sql/moz-fx-data-shared-prod/mozilla_org_derived/gclid_conversions_v3/query.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ dl_token_to_telemetry_id AS (
a.first_seen_date,
a.attribution_dltoken AS dl_token,
FROM
`moz-fx-data-shared-prod.telemetry_derived.clients_first_seen_v2` a
`moz-fx-data-shared-prod.telemetry_derived.clients_first_seen_v3` a
JOIN
dist_dl_tokens b
ON a.attribution_dltoken = b.dl_token
Expand Down

1 comment on commit 9814402

@dataops-ci-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration report for "change from clients_first_seen_v2 to v3 (#6651)"

sql.diff

Click to expand! 
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/dags/bqetl_analytics_tables.py /tmp/workspace/generated-sql/dags/bqetl_analytics_tables.py
--- /tmp/workspace/main-generated-sql/dags/bqetl_analytics_tables.py	2024-12-11 19:46:41.000000000 +0000
+++ /tmp/workspace/generated-sql/dags/bqetl_analytics_tables.py	2024-12-11 19:47:38.000000000 +0000
@@ -543,6 +543,13 @@
         )
 
         ExternalTaskMarker(
+            task_id="bqetl_google_analytics_derived_ga4__wait_for_clients_first_seen_v3",
+            external_dag_id="bqetl_google_analytics_derived_ga4",
+            external_task_id="wait_for_clients_first_seen_v3",
+            execution_date="{{ (execution_date - macros.timedelta(days=-1, seconds=50400)).isoformat() }}",
+        )
+
+        ExternalTaskMarker(
             task_id="bqetl_search__wait_for_clients_first_seen_v3",
             external_dag_id="bqetl_search",
             external_task_id="wait_for_clients_first_seen_v3",
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/dags/bqetl_google_analytics_derived_ga4.py /tmp/workspace/generated-sql/dags/bqetl_google_analytics_derived_ga4.py
--- /tmp/workspace/main-generated-sql/dags/bqetl_google_analytics_derived_ga4.py	2024-12-11 19:46:41.000000000 +0000
+++ /tmp/workspace/generated-sql/dags/bqetl_google_analytics_derived_ga4.py	2024-12-11 19:47:40.000000000 +0000
@@ -118,6 +118,18 @@
         pool="DATA_ENG_EXTERNALTASKSENSOR",
     )
 
+    wait_for_clients_first_seen_v3 = ExternalTaskSensor(
+        task_id="wait_for_clients_first_seen_v3",
+        external_dag_id="bqetl_analytics_tables",
+        external_task_id="clients_first_seen_v3",
+        execution_delta=datetime.timedelta(seconds=36000),
+        check_existence=True,
+        mode="reschedule",
+        allowed_states=ALLOWED_STATES,
+        failed_states=FAILED_STATES,
+        pool="DATA_ENG_EXTERNALTASKSENSOR",
+    )
+
     wait_for_wmo_events_table = BigQueryTableExistenceSensor(
         task_id="wait_for_wmo_events_table",
         project_id="moz-fx-data-marketing-prod",
@@ -567,7 +579,7 @@
     )
 
     mozilla_org_derived__gclid_conversions__v3.set_upstream(
-        wait_for_checks__fail_telemetry_derived__clients_first_seen__v2
+        wait_for_clients_first_seen_v3
     )
 
     mozilla_org_derived__gclid_conversions__v3.set_upstream(
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/gclid_conversions_v3/query.sql /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/gclid_conversions_v3/query.sql
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/gclid_conversions_v3/query.sql	2024-12-11 19:40:53.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/gclid_conversions_v3/query.sql	2024-12-11 19:40:37.000000000 +0000
@@ -45,7 +45,7 @@
     a.first_seen_date,
     a.attribution_dltoken AS dl_token,
   FROM
-    `moz-fx-data-shared-prod.telemetry_derived.clients_first_seen_v2` a
+    `moz-fx-data-shared-prod.telemetry_derived.clients_first_seen_v3` a
   JOIN
     dist_dl_tokens b
     ON a.attribution_dltoken = b.dl_token

Link to full diff

Please sign in to comment.