Skip to content

Commit

Permalink
Fix unregistering of the addon. (#86)
Browse files Browse the repository at this point in the history 
I previously moved away from a data: URL for registration because it
stopped working, but forgot to update the unregistration.
  • Loading branch information
@mhammond
mhammond authored Jun 1, 2022
1 parent e33b4a1 commit 216ed0e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ext_bootstrap.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ function shutdown(data, reason) {
log("extension is shutting down");

// Stop registering about:sync in new processes.
Services.ppmm.removeDelayedProcessScript(DATA_URI_REGISTER_ABOUT);
Services.ppmm.removeDelayedProcessScript("chrome://aboutsync/content/RegisterRedirector.js");
// And unregister about:sync in any processes we've already loaded in.
Services.ppmm.loadProcessScript("chrome://aboutsync/content/UnregisterRedirector.js", true);

Expand Down

1 comment on commit 216ed0e

@firefoxci-taskcluster
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error! Details

Taskcluster-GitHub attempted to create a task for this event with the following scopes:

["assume:repo:github.com/mozilla-extensions/aboutsync:tag:0.19.0","queue:route:checks","queue:scheduler-id:taskcluster-github"]

The expansion of these scopes is not sufficient to create the task, leading to the following:

Client ID static/taskcluster/github does not have sufficient scopes and is missing the following scopes:

assume:repo:github.com/mozilla-extensions/aboutsync:branch:0.19.0

This request requires the client to satisfy the following scope expression:

{
  "AllOf": [
    "assume:repo:github.com/mozilla-extensions/aboutsync:branch:0.19.0",
    "queue:route:checks",
    "queue:route:index.xpi.v2.aboutsync.revision.216ed0e0b2df6e25fbdbe034c4be26e9c46dc5ad.taskgraph.decision",
    "queue:create-task:project:none",
    "queue:scheduler-id:xpi-level-1",
    {
      "AnyOf": [
        "queue:create-task:highest:xpi-1/decision",
        "queue:create-task:very-high:xpi-1/decision",
        "queue:create-task:high:xpi-1/decision",
        "queue:create-task:medium:xpi-1/decision",
        "queue:create-task:low:xpi-1/decision",
        "queue:create-task:very-low:xpi-1/decision",
        "queue:create-task:lowest:xpi-1/decision"
      ]
    }
  ]
}
  • method: createTask
  • errorCode: InsufficientScopes
  • statusCode: 403
  • time: 2022-06-01T14:54:12.076Z

Please sign in to comment.