-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1870891 - Replace native <select> with custom element with search bar #2157
Bug 1870891 - Replace native <select> with custom element with search bar #2157
Conversation
Hmm, all the Selenium tests failed. I assume the headless Firefox instance is too old to support some features:
selenium/standalone-firefox:3.141.59 was released in September 2021. |
a3a6fbb
to
c713707
Compare
Tests are still failing, of course — because I have replaced |
This reverts commit a6f4843.
16f8d28
to
fbf9dab
Compare
All tests passed 🟢 |
Is this ready for review? I can start looking at it right away if so. |
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly everything checks out and looks great! I did see one issue that will need to be resolved. When changing the product on a current bug (show_bug.cgi) the component, version and milestone fields need to be highlighted the same way the current bug page does. This is not happening with the new select. For example:
I have installed your latest changes on bugzilla-dev.allizom.org if you want to see it in action with a large list of components, etc.
Thanks @dklawren! I’ve added the fix for field highlights. |
Bug 1870891 - Replace native
<select>
with custom element with search barThis PR replaces most of the native
<select>
elements on the enter_bug and show_bug pages with new custom elements. A search bar appears when there are 10 or more options for easier filtering. The component dropdown displays the component description in a popover.Implementation note: These dropdown lists and popovers are created using
<dialog>
(modal top layer) instead of the Popover API (non-modal top layer) because the latter is not yet enabled in Firefox other than Nightly. It’s not a problem but just in case some wonder.