Bug 1869601 - GitHub push endpoint should stop setting the qe-verify flag when resolving a Fenix or Focus bug
#2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resolving a Fenix or Focus bug
cgsheeh
approved these changes
Dec 12, 2023
- Add tests back we were doing before for non-android products - Fix uninitialized warning in BugMail.pm when running webservice tests
cgsheeh
requested changes
Dec 13, 2023
| @@ -366,6 +366,7 @@ sub sendMail { | |||
| # Only display bug ids that the user is allowed to see for certain fields | |||
| if ($diff->{field_name} =~ /^(?:dependson|blocked|regress(?:ed_by|es))$/) { | |||
| foreach my $field ('new', 'old') { | |||
| next if !defined $diff->{$field}; | |||
There was a problem hiding this comment.
Yeah snuck that in there as it causes a stderr warning when running the API tests. I can take it if you want and add it to a separate bug
cgsheeh
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.