-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove source builds of geometric_shapes
and srdfdom
#3233
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
==========================================
- Coverage 45.60% 41.81% -3.79%
==========================================
Files 716 704 -12
Lines 62443 57713 -4730
Branches 7558 7559 +1
==========================================
- Hits 28471 24127 -4344
+ Misses 33805 32001 -1804
- Partials 167 1585 +1418 ☔ View full report in Codecov by Sentry. |
Bleh. This error seems familiar but I forget what it was.
Update: Ended up ignoring it, and it makes CI pass, but unclear whether this is right. |
Maybe we hold off on this until moveit/geometric_shapes#258 is released as well? |
This is annoying. Seems that the coverage tool has analyzed files in Is there a better way to clear out this state that doesn't lead to ignoring all missing source code errors? |
Description
We had added these a few months back to circumvent some breakages, but this should no longer be needed.
Q: Should we backport this to Jazzy? Because if so,
srdfdom
there is at 2.0.5 and not 2.0.7, so I think we may need to first release to there. But I also forget whether thesrdfdom
version was actually a problem in Jazzy, or it was just Rolling. I guess it's worth just testing the backport?(self-answer): I just pushed
srdfdom
2.0.7 releases to humble and jazzy on rosdistro.Checklist