Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source builds of geometric_shapes and srdfdom #3233

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Jan 12, 2025

Description

We had added these a few months back to circumvent some breakages, but this should no longer be needed.

Q: Should we backport this to Jazzy? Because if so, srdfdom there is at 2.0.5 and not 2.0.7, so I think we may need to first release to there. But I also forget whether the srdfdom version was actually a problem in Jazzy, or it was just Rolling. I guess it's worth just testing the backport?

(self-answer): I just pushed srdfdom 2.0.7 releases to humble and jazzy on rosdistro.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass added the backport-jazzy Mergify label that triggers a PR backport to Jazzy label Jan 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.81%. Comparing base (9922704) to head (c6ee0d1).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3233      +/-   ##
==========================================
- Coverage   45.60%   41.81%   -3.79%     
==========================================
  Files         716      704      -12     
  Lines       62443    57713    -4730     
  Branches     7558     7559       +1     
==========================================
- Hits        28471    24127    -4344     
+ Misses      33805    32001    -1804     
- Partials      167     1585    +1418     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass
Copy link
Contributor Author

sea-bass commented Jan 12, 2025

Bleh. This error seems familiar but I forget what it was.

geninfo: ERROR: unable to open /opt/ros/rolling/include/srdfdom/srdfdom/model.h: No such file or directory
  	(use "geninfo --ignore-errors source ..." to bypass this error)

Update: Ended up ignoring it, and it makes CI pass, but unclear whether this is right.

@sea-bass
Copy link
Contributor Author

Maybe we hold off on this until moveit/geometric_shapes#258 is released as well?

@sea-bass
Copy link
Contributor Author

sea-bass commented Feb 7, 2025

Bleh. This error seems familiar but I forget what it was.

geninfo: ERROR: unable to open /opt/ros/rolling/include/srdfdom/srdfdom/model.h: No such file or directory
  	(use "geninfo --ignore-errors source ..." to bypass this error)

Update: Ended up ignoring it, and it makes CI pass, but unclear whether this is right.

This is annoying. Seems that the coverage tool has analyzed files in geometric_shapes that were previously cloned via vcs, but removing this is what causes the issue.

Is there a better way to clear out this state that doesn't lead to ignoring all missing source code errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy Mergify label that triggers a PR backport to Jazzy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants