Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-292365: Support Flex Clusters #2030

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

CLOUDP-292365: Support Flex Clusters #2030

wants to merge 33 commits into from

Conversation

roothorp
Copy link
Collaborator

@roothorp roothorp commented Jan 9, 2025

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@roothorp
Copy link
Collaborator Author

roothorp commented Jan 9, 2025

Currently failing tests (need to change some more tests to use SdkClientSet), and needs rebasing once I'm done with that, but hopefully gives an insight.

josvazg
josvazg reviewed Jan 9, 2025
View reviewed changes
test/helper/contract/ako.go Outdated Show resolved Hide resolved
josvazg
josvazg reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, not approving yet as ti is still draft.

I really liked the way you sliced it into separate commits, easier to focus on reviewing each of them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg left review comments

@s-urbaniak s-urbaniak s-urbaniak left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roothorp @s-urbaniak @josvazg