CLOUDP-268809: IP Access List CRD #2027
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
requested review from
s-urbaniak,
josvazg,
igor-karpukhin and
roothorp
helderjs
force-pushed
the
CLOUDP-268809-ip-access-list-crd
branch
from
5006f11 to
208e040
Compare
josvazg
reviewed
Jan 9, 2025
josvazg
reviewed
Jan 9, 2025
api/v1/atlasipaccesslist_types.go
Outdated
Comment on lines
34
to
42
| type AtlasIPAccessListSpec struct { | ||
| // Project is a reference to AtlasProject resource the user belongs to | ||
| // +kubebuilder:validation:Optional | ||
| Project *common.ResourceRefNamespaced `json:"projectRef,omitempty"` | ||
| // ExternalProject holds the Atlas project ID the user belongs to | ||
| // +kubebuilder:validation:Optional | ||
| ExternalProject *ExternalProjectReference `json:"externalProjectRef,omitempty"` | ||
| // Local credentials | ||
| api.LocalCredentialHolder `json:",inline"` |
There was a problem hiding this comment.
Holding this PR for this rebase
josvazg
reviewed
Jan 9, 2025
api/v1/atlasipaccesslist_types.go
Outdated
| Items []AtlasIPAccessList `json:"items"` | ||
| } | ||
|
|
||
| func (ial *AtlasIPAccessList) AtlasProjectObjectKey() client.ObjectKey { |
There was a problem hiding this comment.
This code can be a common method for all users of dual project references.
helderjs
force-pushed
the
CLOUDP-268809-ip-access-list-crd
branch
from
208e040 to
9f70d8f
Compare
josvazg
requested changes
Jan 10, 2025
helderjs
force-pushed
the
CLOUDP-268809-ip-access-list-crd
branch
from
9f70d8f to
a86a433
Compare
josvazg
reviewed
Jan 14, 2025
josvazg
reviewed
Jan 14, 2025
josvazg
reviewed
Jan 14, 2025
helderjs
force-pushed
the
CLOUDP-268809-ip-access-list-crd
branch
2 times, most recently
from
4d87caa to
998be22
Compare
s-urbaniak
reviewed
Jan 16, 2025
s-urbaniak
reviewed
Jan 16, 2025
s-urbaniak
approved these changes
Jan 17, 2025
helderjs
force-pushed
the
CLOUDP-268809-ip-access-list-crd
branch
from
998be22 to
02c1596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).