MONGOCRYPT-767 Increase tag count field size to 32 bits for text search types #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I opted to make |
marksg07
requested changes
Feb 18, 2025
erwee
approved these changes
Feb 18, 2025
marksg07
requested changes
Feb 20, 2025
| @@ -196,14 +196,14 @@ static bool _mc_fle2_iev_v2_test_parse(_mc_fle2_iev_v2_test *test, bson_iter_t * | |||
| ASSERT_OR_PRINT_MSG(!test->substr_tag_count, "Duplicate field 'substr_tag_count'"); | |||
| ASSERT(BSON_ITER_HOLDS_INT32(iter) || BSON_ITER_HOLDS_INT64(iter)); | |||
| int64_t value = bson_iter_as_int64(iter); | |||
| ASSERT_OR_PRINT_MSG((value >= 0) && (value < 256), "Field 'substr_tag_count' must be 0..255"); | |||
| test->substr_tag_count = (uint8_t)value; | |||
| ASSERT_OR_PRINT_MSG((value >= 0) && (value < UINT32_MAX), "Field 'substr_tag_count' must be 0..2^32-1"); | |||
There was a problem hiding this comment.
Could we add a positive test with counts larger than 8-bit? You can generate one by printing the result of _mc_fle2_iev_v2_test_serialize_payload on a _mc_fle2_iev_v2_test object constructed from a JSON file without a payload field. The metadata fields can just be duplicated as many times as you need; we don't do checks beyond validity on them.
| @@ -624,13 +636,13 @@ static inline uint32_t mc_FLE2IndexedEncryptedValueV2_serialized_length(const mc | |||
| // fle_blob_subtype: 1 byte | |||
There was a problem hiding this comment.
What do you mean? I still see uint8_t on line 619.
marksg07
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.