Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoC: remove 'Monero Maintainer Team' #9735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Jan 26, 2025

Should selsta be on here? Should I be on here?

It's not entirely clear if this is:

  • a list of maintainers
  • a special team of (non-)maintainers?

I'd like to get some input from others here.

@selsta
Copy link
Collaborator

selsta commented Jan 26, 2025

Maybe just remove the list? There is also no list of administrators or contributors.

Currently it does not make sense, moneromooo and hyc don't have merge access.

@tobtoht
Copy link
Collaborator Author

tobtoht commented Jan 26, 2025

Neither does fluffy since he stepped down I think. Removing the list seems reasonable, but then maybe we should clarify/change:

Maintainers MUST NOT merge pull requests in less than 168 hours (1 week) unless deemed urgent by at least 2 people from the Monero Maintainer Team.

to

Maintainers MUST NOT merge pull requests in less than 168 hours (1 week) unless deemed urgent by at least 2 Maintainers.

?

@selsta
Copy link
Collaborator

selsta commented Jan 26, 2025

seems good to me

@tobtoht tobtoht force-pushed the docs_maintainer_team branch from f4874de to 69020aa Compare January 26, 2025 16:28
@tobtoht tobtoht changed the title docs: update 'Monero Maintainer Team' docs: remove 'Monero Maintainer Team' Jan 26, 2025
@tobtoht tobtoht marked this pull request as ready for review January 26, 2025 16:30
@jeffro256
Copy link
Contributor

This list is definitely a bit out of date, and is probably worth removing, but this just shifts the question to: who are "the maintainers"?

@tobtoht
Copy link
Collaborator Author

tobtoht commented Jan 26, 2025

If maintainer means: 'users who have write access':

  • binaryFate
  • luigi1111
  • tobtoht

(I don't have enough permissions to verify this, I'm going by this comment from luigi)

If it means: 'users who actively merge commits':

  • luigi1111
  • tobtoht

If it means: 'users who decide what gets merged':

  • selsta

Edit: Just to clarify my position here: I do think we should specify which group is meant by "Maintainers".

@tobtoht
Copy link
Collaborator Author

tobtoht commented Jan 29, 2025

Any opinions on this?

I view selsta as a maintainer despite him not having merge rights. We could opt to keep the list and update it to luigi1111, selsta, and me for now.

@selsta
Copy link
Collaborator

selsta commented Jan 29, 2025

I don't consider myself a maintainer and would prefer to also not be listed as one. It also would not match with the document.

A "Maintainer" is a person who merges patches to the project. Maintainers are not developers; their job is to enforce process.

@tobtoht
Copy link
Collaborator Author

tobtoht commented Jan 29, 2025

Ok, given the description I think it follows that luigi1111 and I are currently the only maintainers. We don't have to explicitly document this.

@tobtoht tobtoht changed the title docs: remove 'Monero Maintainer Team' CoC: remove 'Monero Maintainer Team' Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants