Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: remove msvc #9729

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmake: remove msvc #9729

wants to merge 1 commit into from
+22 −50

Conversation

tobtoht
Copy link
Collaborator

@tobtoht tobtoht commented Jan 26, 2025

We don't support MSVC, so let's not pretend like we do.

0xFFFC0000
0xFFFC0000 approved these changes Jan 26, 2025
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this, since our MSVC support is not working not robust.

But eventually we might want to implement it because of debugging on windows.

Even if we want to add msvc support, these code must be cleaned up and removed.

Appreciate it.

iamamyth
iamamyth approved these changes Jan 26, 2025
View reviewed changes
Copy link

@iamamyth iamamyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the PR description: Vaguely attempted, but failed, MSVC support only serves to confuse other maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

@iamamyth iamamyth iamamyth approved these changes

Assignees
No one assigned
Labels
build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobtoht @iamamyth @0xFFFC0000 @selsta