Skip to content

Commit

Permalink
Bugfix: torsions in 3-membered rings
Browse files Browse the repository at this point in the history
* The code allowed the torsion around a 3-membered ring which had the same atom at
  each end of the torsion. This is not a valid torsion, and the code now checks for
  it and removes it.
  • Loading branch information
paulsaxe committed Jan 21, 2025
1 parent 8fb705d commit 47942df
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
=======
History
=======
2025.1.21 -- Bugfix: torsions in 3-membered rings
* The code allowed the torsion around a 3-membered ring which had the same atom at
each end of the torsion. This is not a valid torsion, and the code now checks for
it and removes it.

2024.6.27 -- Support for local forcefield files
* Added support for local forcefields files which can either be used directly
or included by existing files.
Expand Down
3 changes: 3 additions & 0 deletions seamm_ff_util/forcefield.py
Original file line number Diff line number Diff line change
Expand Up @@ -2508,6 +2508,9 @@ def setup_topology(self, configuration, style=""):
for l in bonds_from_atom[k]: # noqa: E741
if l == j: # noqa: E741
continue
if i == l:
# 3 membered rings.
continue
torsions.append((i, j, k, l))

# Out-of-planes
Expand Down

0 comments on commit 47942df

Please sign in to comment.