MRG: Test PSD topomap works with NIRS epochs #8180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-luke
changed the title
|
@larsoner @agramfort this is ready for review |
larsoner
approved these changes
Sep 1, 2020
Yeah I have just started exploring a more time/frequency style of analysis, I think a tutorial would be worthwhile once I've wrapped my head around the best use cases. But that might be a while (manuscript first 😉). Meanwhile, I could add a token |
|
Nah, good enough :) |
larsoner
added a commit
to hubertjb/mne-python
that referenced
this pull request
Sep 2, 2020
…ysionet * upstream/master: ENH: Add message (mne-tools#8193) ENH: Allow writing BEM in H5 format (mne-tools#8191) ENH: Add ori on MRI slices (mne-tools#8188) Ricoh new files (mne-tools#8187) MRG: Split _timeviewer.py into multiple files (mne-tools#8181) ENH: Better memory efficiency (mne-tools#8185) MRG: Trimming Sleep Physionet recordings to avoid W imbalance (mne-tools#8179) MRG, BUG: Fix montage plotting, deduplication, and preload check (mne-tools#8178) Test PSD topomap works with NIRS epochs (mne-tools#8180) MRG, MAINT: Tweak CI versions (mne-tools#8174)
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Ticking off a few of the last issues from #7057
What does this implement/fix?
Turns out psd topomap already worked due to previous code changes. So I just added a test to ensure it continues working.