-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Add nirs support to plot_evoked_topo #7408
Conversation
@larsoner could you please review. The function now behaves as I would expect. The CI errors seem unrelated to the code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems travis failures are unrelated.
Codecov Report
@@ Coverage Diff @@
## master #7408 +/- ##
==========================================
+ Coverage 90.01% 90.03% +0.01%
==========================================
Files 453 454 +1
Lines 82233 82214 -19
Branches 13012 13002 -10
==========================================
- Hits 74023 74022 -1
+ Misses 5384 5368 -16
+ Partials 2826 2824 -2 |
Sorry to modify this after you approved @agramfort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 for merge with or without my pytest
enhancement. @rob-luke I'll let you decide whether or not to do it, depends on how much you want to dig into pytest
magic :)
Ok don’t merge. And I will try this fancy pytest stuff. |
Thanks @larsoner I think I have implemented your suggestion. Can you please review again. |
Thanks @rob-luke ! |
Reference issue
Adding general NIRS support #7057
What does this implement/fix?
Allows plotting of evoked topo map for nirs data