Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HELIO-4295 update resque, resque-web, resque-pool #3301

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

sethaj
Copy link
Member

@sethaj sethaj commented Jul 5, 2022

added 'font-awesome-sass' for resque-web
copied over app/views/layouts/resque_web/application.html.erb for
resque_web, resque/resque-web#156

added 'font-awesome-sass' for resque-web
copied over app/views/layouts/resque_web/application.html.erb for
resque_web, resque/resque-web#156
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<span class="icon-bar"></span>
<span class="icon-bar"></span>
</a>
<%= image_tag "resque_web/lifebuoy.png", class: 'logo' %>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

@conorom conorom merged commit 2bad6e5 into master Jul 6, 2022
@conorom conorom deleted the update-resque branch July 6, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants