-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back to generic env for selectors #5379
Conversation
When an entity type does not have a specific CEL environment, fall back to the generic environment. Fix #5375
Note: This PR does not add support for the |
Can we have a general way for entities to use selectors via properties? That way we wouldn't have these entity specific pieces of code. |
Hmm -- the way I see it is:
Does that make sense? If so, I'd like it to be required (e.g. compile error if not implemented) for entities to implement enough of "expose properties" to support selectors. I think that could end up with a generic "entity" and properties extracted from it, or a few other routes. |
Entities already all should have Properties, and the protobuf provides a GetProperties function. So... we should already be able to generalize |
I wrote #5380 to be generic. I'll copy this conversation over to that issue. |
Summary
When an entity type does not have a specific CEL environment, fall back to the generic environment.
Fix #5375
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: