Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pool/operator/service params #61

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Jul 29, 2024

Description

This PR adds various parameters to pool/operator/service.

  • Added OperatorParams. It has:
    • commission_rate
    • joined_service_ids
  • Added ServiceParams. It has:
    • slash_fraction
    • whitelisted_pool_ids
    • whitelisted_operator_ids
  • Added allowed_service_ids to x/pools Params
  • Added new x/restaking msgs
    • MsgUpdateOperatorParams
    • MsgUpdateServiceParams
  • Added new x/restaking queries that return the default params if params are not set
    • QueryOperatorParamsRequest
    • QueryServiceParamsRequest

Closes: MILK-63


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@hallazzang hallazzang self-assigned this Jul 29, 2024
@hallazzang hallazzang force-pushed the hallazzang/service-and-operator-params branch from ad97cda to f72ddb9 Compare July 30, 2024 10:51
@hallazzang hallazzang changed the title feat: add OperatorParams and ServiceParams feat: add pool/operator/service params Jul 30, 2024
@hallazzang hallazzang requested review from manu0466 and RiccardoM July 30, 2024 10:57
@hallazzang hallazzang marked this pull request as ready for review July 30, 2024 10:58
Copy link
Contributor

@manu0466 manu0466 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code looks good to me. I’ve just left some comments on a few things that I didn’t understand.

x/restaking/keeper/msg_server.go Show resolved Hide resolved
x/restaking/keeper/msg_server.go Show resolved Hide resolved
x/pools/types/keys.go Show resolved Hide resolved
@hallazzang hallazzang requested a review from manu0466 July 30, 2024 13:43
Copy link
Contributor

@manu0466 manu0466 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hallazzang hallazzang merged commit 3837d23 into main Jul 31, 2024
17 checks passed
@hallazzang hallazzang deleted the hallazzang/service-and-operator-params branch July 31, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants