feat: add restaking client and invariants #56
Conversation
x/restaking/client/cli/query.go
Outdated
| // GetPoolsQueryCmd returns the command allowing to query pools | ||
| func GetPoolsQueryCmd() *cobra.Command { | ||
| queryCmd := &cobra.Command{ | ||
| Use: "pools", |
There was a problem hiding this comment.
How about use "pool" instead? That way, the full command will look like:
milkywayd tx restaking pool delegations 1milkywayd tx restaking pool delegation 1 init1...
x/restaking/client/cli/tx.go
Outdated
| txCmd.AddCommand( | ||
| GetPoolsTxCmd(), | ||
| GetOperatorsTxCmd(), | ||
| GetServicesTxCmd(), | ||
| ) |
There was a problem hiding this comment.
I understand it's just a personal preference, but here are my suggestions:
milkywayd tx restaking delegate-pool 1000000umilkmilkywayd tx restaking delegate-operator 1 1000000umilkmilkywayd tx restaking delegate-service 2 1000000umilk
Or
milkywayd tx restaking delegate pool 1000000umilkmilkywayd tx restaking delegate operator 1 1000000umilkmilkywayd tx restaking delegate service 2 1000000umilk
What do you think?
There was a problem hiding this comment.
Thanks for the suggestion, will update it to follow the second one (delegate <pool|operator|service>) 🙏
x/restaking/keeper/invariants.go
Outdated
| poolsBroken := !poolsBalances.Equal(poolsTokens) | ||
| operatorsBroken := !operatorsBalances.Equal(operatorsTokens) | ||
| servicesBroken := !servicesBalances.Equal(servicesTokens) |
There was a problem hiding this comment.
We should these instead:
| poolsBroken := !poolsBalances.Equal(poolsTokens) | |
| operatorsBroken := !operatorsBalances.Equal(operatorsTokens) | |
| servicesBroken := !servicesBalances.Equal(servicesTokens) | |
| poolsBroken := !poolsBalances.IsAllGTE(poolsTokens) | |
| operatorsBroken := !operatorsBalances.IsAllGTE(operatorsTokens) | |
| servicesBroken := !servicesBalances.IsAllGTE(servicesTokens) |
Because an attacker can send assets to the module addresses to halt the chain with this invariant.
There was a problem hiding this comment.
@RiccardoM Can you check this again please?
There was a problem hiding this comment.
Fixed. Must've been the rebase that brought it back 🤦
feat: rename pools command to pool instead
feat: rename pools query command to pool
RiccardoM
force-pushed
the
riccardom/add-restaking-cli
branch
from
9dfb3a4 to
5d0f213
Compare
x/restaking/keeper/invariants.go
Outdated
| poolsBroken := !poolsBalances.Equal(poolsTokens) | ||
| operatorsBroken := !operatorsBalances.Equal(operatorsTokens) | ||
| servicesBroken := !servicesBalances.Equal(servicesTokens) |
There was a problem hiding this comment.
@RiccardoM Can you check this again please?
Description
This PR adds the
x/restakingCLI client as well as invariants.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change