feat!: add investors module #250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep VestingAccountsRewardRatio as the module's state - simplify hooks logic
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
this way we can simplify InitGenesis logic by not re-calculating validators investors shares. when investors' vesting periods end, they'll be removed in the begin blocker anyway
|
@hallazzang Can you rebase your changes on top of |
hallazzang
force-pushed
the
hallazzang/limit-vesting-acc-rewards-poc
branch
from
b035a69 to
6c4cd3d
Compare
staking keeper's Unbond already calls BeforeDelegationSharesModified so calling it inside BeforeDelegationRemoved hook results in decrementing vesting investor's shares twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new module, x/investors, designed to limit the staking rewards allocated to vesting investors.
Closes: MILK-220
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change