Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes #254

Merged
merged 14 commits into from
Jun 6, 2021
Merged

Some fixes #254

merged 14 commits into from
Jun 6, 2021

Conversation

LukasForst
Copy link
Member

@LukasForst LukasForst commented Jun 5, 2021 •
edited
Loading

tomaskourim
tomaskourim requested changes Jun 5, 2021
View reviewed changes
Copy link
Member

@tomaskourim tomaskourim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rychle jsem to prolitl. Vypada to ok. Ale urcite s mergovanim pockejme nez bude nova ENV promenna nastavena. A take by to podle me chtel videl @tomaspavlin, protoze to upravuje i jeho kod.

backend/src/main/kotlin/blue/mild/covid/vaxx/error/ExceptionHandling.kt
exception<InsufficientRightsException> {
logger.warn {
logger.warn(it) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to asi neni potreba, it uz nepouzijes. Ne?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicmene bys mohl mozna...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tohle se pouzije, protoze se to propise do finalniho jsonu jako "exception": {...} tzn v AWS uvidime celej stacktrace - to mi prijde uzitecne

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jakoze bez toho it se nevypise stacktrace, jo? Potom to samozrejme chceme

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

presne tak

@tomaskourim tomaskourim requested a review from tomaspavlin June 5, 2021 09:14
@LukasForst LukasForst mentioned this pull request Jun 5, 2021
Closed
@tomaskourim
Copy link
Member

Hele za mě je to ok jenom nesmíme zapomenout na ten env na produkci

@LukasForst
Copy link
Member Author

image
env je nastavena -> related PR https://github.com/mild-blue/project-configuration/pull/43

tomaskourim
tomaskourim approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@tomaskourim tomaskourim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

velky PR, rychle zkontrolovany a vypada gut

backend/src/main/kotlin/blue/mild/covid/vaxx/error/ExceptionHandling.kt
exception<InsufficientRightsException> {
logger.warn {
logger.warn(it) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jakoze bez toho it se nevypise stacktrace, jo? Potom to samozrejme chceme

@tomaskourim tomaskourim merged commit 64a0c4f into master Jun 6, 2021
@tomaskourim tomaskourim deleted the lukas-fix branch June 6, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskourim tomaskourim tomaskourim approved these changes

@tomaspavlin tomaspavlin Awaiting requested review from tomaspavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad request Time around interval Check rate limiter
3 participants
@LukasForst @tomaskourim @misslecter